timsaucer commented on code in PR #1242:
URL:
https://github.com/apache/datafusion-python/pull/1242#discussion_r2364913936
##########
python/datafusion/dataframe.py:
##########
@@ -415,7 +415,14 @@ def drop(self, *columns: str) -> DataFrame:
Returns:
DataFrame with those columns removed in the projection.
"""
Review Comment:
Thank you for the PR. This looks good. One request: Would you mind updating
the docstring to specify that column case is respected and does not need double
quotes like other operations such as `select`? You can also specify that
leading and trailing `"` are allowable as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
