alamb commented on code in PR #17708:
URL: https://github.com/apache/datafusion/pull/17708#discussion_r2367445243
##########
datafusion/wasmtest/Cargo.toml:
##########
@@ -60,4 +60,4 @@ object_store = { workspace = true }
# needs to be compiled
tokio = { workspace = true }
url = { workspace = true }
-wasm-bindgen-test = "0.3.51"
+wasm-bindgen-test = "=0.3.51"
Review Comment:
I think it would help future readers to leave a int about why this is pinned
```suggestion
# Pinned due to
https://github.com/apache/datafusion/pull/17642#issuecomment-3317307943
wasm-bindgen-test = "=0.3.51"
```
##########
Cargo.lock:
##########
@@ -1736,38 +1734,14 @@ version = "0.2.2"
source = "registry+https://github.com/rust-lang/crates.io-index";
checksum = "b365fabc795046672053e29c954733ec3b05e4be654ab130fe8f1f94d7051f35"
-[[package]]
Review Comment:
it is nice to see a bunch of older crates no longer needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
