alan910127 commented on issue #17158: URL: https://github.com/apache/datafusion/issues/17158#issuecomment-3319020326
Thanks, @alamb! While digging into `expr_simplifier.rs`, I noticed the LLVM-style approach could potentially handle both `Simplifier` and `ConstEvaluator`. Do you have suggestions on how this might fit into the current logic? One difference I saw is that we currently use cycle counts to limit planning time, whereas LLVM tries to simplify in one pass and limits recursion depth instead. Do you think it would make sense to adapt that model here, or should we stick with the cycle-count approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
