blaginin commented on code in PR #17694:
URL: https://github.com/apache/datafusion/pull/17694#discussion_r2372999956
##########
.github/workflows/rust.yml:
##########
@@ -308,17 +308,20 @@ jobs:
name: cargo test datafusion-cli (amd64)
needs: linux-build-lib
runs-on: ubuntu-latest
- # should be uncommented once
https://github.com/apache/datafusion/pull/16644 is merged
- # and cache should be added
- # container:
- # image: amd64/rust
+ container:
+ image: amd64/rust
Review Comment:
Hey! I think I tried using `amd64/rust` container (so we would install fewer
tools on top), but it wasn't possible because we were manually starting Minio
(via `docker run ...`). When I wrote this TODO, I guess I was thinking we'd
come up with a way to spawn Minio without docker.
Now we're using testcontainers, but I imagine they need Docker to work, so I
guess we can't really switch the container. it's probably fine to remove the
TODO 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
