comphead commented on code in PR #2429:
URL: https://github.com/apache/datafusion-comet/pull/2429#discussion_r2376425048


##########
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##########
@@ -1031,9 +1031,6 @@ class CometExecSuite extends CometTestBase {
           |GROUP BY key
               """.stripMargin)
 
-      // The above query uses COUNT(DISTINCT) which Comet doesn't support yet, 
so the plan will
-      // have a mix of `HashAggregate` and `CometHashAggregate`. In the 
following we check all
-      // operators starting from `CometHashAggregate` are native.
       checkSparkAnswer(df)

Review Comment:
   we can probably do it in followup PRs, this test contains 
   
   ```
     sum(distinct value1),
     count(distinct value1, value2),
   ```
   
   both of them falls to spark now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to