kosiew opened a new issue, #17765:
URL: https://github.com/apache/datafusion/issues/17765
# 6. Switch adapter to `CastColumnExpr` and add behavior tests
* **Goal:** Make `PhysicalExprAdapter` reuse the struct-aware casting path
for schema mismatches and validate behavior end-to-end.
* **Scope & Location:** `schema_rewriter.rs`, adapter integration tests,
potentially shared test utilities.
* **Key Tasks:**
* Replace the fallback `CastExpr` creation with `CastColumnExpr`
instantiation when rewriting columns.
* Ensure new quick compatibility checks determine when no cast is
necessary.
* Add integration-style tests covering predicates with missing struct
fields, differing nullability, and nested structs to confirm correct coercion.
* Update any documentation or comments referencing the old behavior.
* **Dependencies:** Requires specs #1–5 to be merged (expression, utilities,
serialization, pruning, and refactor).
* **Out of Scope:** Additional optimizer/planner features beyond the adapter
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
