iffyio commented on code in PR #2044:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2044#discussion_r2379313920
##########
src/dialect/ansi.rs:
##########
@@ -33,4 +33,9 @@ impl Dialect for AnsiDialect {
fn require_interval_qualifier(&self) -> bool {
true
}
+
+ // The SQL standard explictly states that block comments nest.
Review Comment:
```suggestion
/// The SQL standard explictly states that block comments nest.
```
##########
src/dialect/databricks.rs:
##########
@@ -64,4 +64,9 @@ impl Dialect for DatabricksDialect {
fn supports_struct_literal(&self) -> bool {
true
}
+
+ //
https://docs.databricks.com/aws/en/sql/language-manual/sql-ref-syntax-comment
Review Comment:
```suggestion
///
https://docs.databricks.com/aws/en/sql/language-manual/sql-ref-syntax-comment
```
##########
src/dialect/clickhouse.rs:
##########
@@ -94,4 +94,10 @@ impl Dialect for ClickHouseDialect {
fn supports_group_by_with_modifier(&self) -> bool {
true
}
+
+ // Supported since 2020.
+ // See
<https://clickhouse.com/docs/whats-new/changelog/2020#backward-incompatible-change-2>
Review Comment:
```suggestion
/// Supported since 2020.
/// See
<https://clickhouse.com/docs/whats-new/changelog/2020#backward-incompatible-change-2>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
