Dandandan commented on code in PR #17757:
URL: https://github.com/apache/datafusion/pull/17757#discussion_r2379420381
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -618,12 +618,12 @@ async fn test_aggregate_with_pk2() -> Result<()> {
let df = df.filter(predicate)?;
assert_snapshot!(
physical_plan_to_string(&df).await,
- @r###"
- CoalesceBatchesExec: target_batch_size=8192
- FilterExec: id@0 = 1 AND name@1 = a
- AggregateExec: mode=Single, gby=[id@0 as id, name@1 as name], aggr=[]
+ @r"
+ AggregateExec: mode=Single, gby=[id@0 as id, name@1 as name], aggr=[],
ordering_mode=Sorted
+ CoalesceBatchesExec: target_batch_size=8192
+ FilterExec: id@0 = 1 AND name@1 = a
Review Comment:
Nice, looks like a small improvement (although removing the aggregate would
also be possible in this case 🤔 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
