devampatel03 commented on issue #17469:
URL: https://github.com/apache/datafusion/issues/17469#issuecomment-3334891167
@waynexia, yeah sure we can apply the same logic for `Window Functions` . I
have applied the same logic there, and after updating the tests, it's working
perfectly.
I'll create a new PR regarding the window functions alias changes.
Also I noticed something interesting while updating the snapshot, it looks
like many of the existing `window function` tests have very long default column
output names that include the full `PARTITION BY` , `ORDER BY` and `OVER`
clauses which are not required in output.
I have updated the snapshot for the `window function` alias test which now
has a shorter column same as it's there in scalar and aggregate function tests.
I think it would be a great follow-up to normalize all of them for
consistency, but that's probably best handled in a separate issue and PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
