Jefffrey opened a new pull request, #17780:
URL: https://github.com/apache/datafusion/pull/17780
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #4259
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
#4259 was actually resolved by #11721, however I noticed this same fix
wasn't applied on `approx_percentile_cont_with_weight`. Fixing it for this
function too.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
When updating batches in the `ApproxPercentileWithWeightAccumulator`, filter
out null values in both arrays (taking care to filter out corresponding value
in other array if partner value is null). Also add a debug assert in
`ApproxPercentileAccumulator::convert_to_float` to ensure we don't accidentally
pass in arrays with nulls again.
Also fix some visibility modifiers on `ApproxPercentileAccumulator` methods.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Added SLT tests.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
API change technically as changing some methods in
`ApproxPercentileAccumulator` from `pub` to `pub(crate)`; I don't think these
were meant to be `pub` in the first place based on the comments. I can revert
this change if we decide to just leave them in the public API.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
