Jefffrey commented on code in PR #17798:
URL: https://github.com/apache/datafusion/pull/17798#discussion_r2383733928
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -2135,7 +2135,15 @@ impl DefaultPhysicalPlanner {
"Optimized physical plan:\n{}\n",
displayable(new_plan.as_ref()).indent(false)
);
- debug!("Detailed optimized physical plan:\n{new_plan:?}");
+
+ // Don't print new_plan directly, as that may overflow the stack.
+ // For example:
+ // thread 'tokio-runtime-worker' has overflowed its stack
+ // fatal runtime error: stack overflow, aborting
+ debug!(
+ "Detailed optimized physical plan:\n{}\n",
+ displayable(new_plan.as_ref()).indent(true)
+ );
Review Comment:
Consistent with the logging at the top of this function 👍
https://github.com/apache/datafusion/blob/deba0069ae5b3bc3a22d8dd3038718a566e98bb0/datafusion/core/src/physical_planner.rs#L2096-L2103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
