Jefffrey commented on PR #17805: URL: https://github.com/apache/datafusion/pull/17805#issuecomment-3350646471
> In my mind this is mostly for backwards compatibility reasons -- https://github.com/apache/datafusion/pull/13511 basically broke a bunch of our existing user queries, so I wanted to revert the unnecessarily strict interpretation > I suggest we hold off unless someone explicitly asks about it, though I am not opposed to it either I might raise a separate issue to track keeping the SQL API & DataFrame API in parity in regards to this; especially for when we consider adding more ordered set aggregate functions, if we should enforce `WITHIN GROUP` for those but not existing ones. > Though allowing different arguments means you can write expressions like `approx_median(first_name ORDER BY salary WITHIN GROUP)` and save yourself a subquery I'm a bit confused by this example; is this just a hypothetical or something that is feasible with ordered set aggregate functions? I thought they would expected one column/expression which is the same as the `ORDER BY` in the `WITHIN GROUP` 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
