coderfender commented on code in PR #2472:
URL: https://github.com/apache/datafusion-comet/pull/2472#discussion_r2395200650
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -322,8 +322,7 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(generateInts(), DataTypes.DoubleType)
}
- ignore("cast IntegerType to DecimalType(10,2)") {
- // Comet should have failed with [NUMERIC_VALUE_OUT_OF_RANGE] -1117686336
cannot be represented as Decimal(10, 2)
+ test("cast IntegerType to DecimalType(10,2)") {
Review Comment:
@parthchandra , @andygrove . I added tests below per the suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
