kosiew commented on code in PR #17773: URL: https://github.com/apache/datafusion/pull/17773#discussion_r2396969243
########## datafusion/physical-expr/src/expressions/cast_column.rs: ########## @@ -0,0 +1,409 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Physical expression for struct-aware casting of columns. + +use crate::physical_expr::PhysicalExpr; +use arrow::{ + compute::CastOptions, + datatypes::{DataType, FieldRef, Schema}, + record_batch::RecordBatch, +}; +use datafusion_common::{ + format::DEFAULT_CAST_OPTIONS, nested_struct::cast_column, Result, ScalarValue, +}; +use datafusion_expr_common::columnar_value::ColumnarValue; +use std::{ + any::Any, + fmt::{self, Display}, + hash::Hash, + sync::Arc, +}; +/// A physical expression that applies [`cast_column`] to its input. Review Comment: The initial plan was to `Replace the fallback CastExpr creation with CastColumnExpr instantiation when rewriting columns.` when I work on #17765 I will change #17765 to instead `update the existing CastExpr to handle Fields rather than introduce a new CastColumnExpr ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
