parthchandra commented on PR #2514:
URL:
https://github.com/apache/datafusion-comet/pull/2514#issuecomment-3358664605
> > @parthchandra will the jars for Spark 3.x still work with JDK 11, or do
we also need to update the target java version in the Maven build?
>
> Let me verify that.
The jars for Spark 3.x will work with JDK 11.
The pom file already specifies
```
<java.version>11</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
```
For the spark 4.0 profile this is overridden with
```
<java.version>17</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
```
Also the compiler plugin specifies the configured version so it is all
consistent.
```
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>${maven-compiler-plugin.version}</version>
<configuration>
<source>${java.version}</source>
<target>${java.version}</target>
<skipMain>true</skipMain>
<skip>true</skip>
</configuration>
</plugin>
```
I also built with JDK 17 and the byte code versions for the default profile
(Spark 3.5) were compatible with JDK 8 (major version 52) for the classes I
checked. With the spark-4.0 profile the bytecode versions corresponded to JDK
17 (major version 61)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
