joroKr21 commented on code in PR #17675:
URL: https://github.com/apache/datafusion/pull/17675#discussion_r2390547786
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1994,32 +2005,29 @@ pub fn table_scan_with_filter_and_fetch(
)
}
-pub fn table_source(table_schema: &Schema) -> Arc<dyn TableSource> {
- // TODO should we take SchemaRef and avoid cloning?
Review Comment:
@alamb should I understand that you prefer to keep this change although it's
breaking? Or should I rather revert it?
> > I think the changes to avoid Schema clones will help , though I just
double checked and a Schema is mostly an empty HashMap and an Arc (Fields) so
clone'ing isn't that expensive.
> That's a good point, I didn't look into it. I'm open to reverting the
changes in the logical plan builder from SchemaRef back to &Schema to reduce
breaking changes but I wouldn't change logical2physical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
