iffyio commented on code in PR #2054:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2054#discussion_r2403806157
##########
src/ast/table_constraints/check_constraint.rs:
##########
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I think we can use a single file `table_constraints.rs` to contain the new
structs, vs having one struct per file. So that we don't end up accumulating a
lot of small files which would be the other extreme of where we are today
##########
src/ast/ddl.rs:
##########
@@ -2065,7 +1902,7 @@ pub enum GeneratedExpressionMode {
}
#[must_use]
-fn display_constraint_name(name: &'_ Option<Ident>) -> impl fmt::Display + '_ {
+pub fn display_constraint_name(name: &'_ Option<Ident>) -> impl fmt::Display +
'_ {
Review Comment:
```suggestion
pub(crate) fn display_constraint_name(name: &'_ Option<Ident>) -> impl
fmt::Display + '_ {
```
##########
src/ast/ddl.rs:
##########
@@ -2082,7 +1919,7 @@ fn display_constraint_name(name: &'_ Option<Ident>) ->
impl fmt::Display + '_ {
/// * `Some(inner)` => create display struct for `"{prefix}{inner}{postfix}"`
/// * `_` => do nothing
#[must_use]
-fn display_option<'a, T: fmt::Display>(
+pub fn display_option<'a, T: fmt::Display>(
Review Comment:
```suggestion
pub(crate) fn display_option<'a, T: fmt::Display>(
```
##########
src/ast/ddl.rs:
##########
@@ -2104,7 +1941,7 @@ fn display_option<'a, T: fmt::Display>(
/// * `Some(inner)` => create display struct for `" {inner}"`
/// * `_` => do nothing
#[must_use]
-fn display_option_spaced<T: fmt::Display>(option: &Option<T>) -> impl
fmt::Display + '_ {
+pub fn display_option_spaced<T: fmt::Display>(option: &Option<T>) -> impl
fmt::Display + '_ {
Review Comment:
```suggestion
pub(crate) fn display_option_spaced<T: fmt::Display>(option: &Option<T>) ->
impl fmt::Display + '_ {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
