dqkqd commented on code in PR #17921:
URL: https://github.com/apache/datafusion/pull/17921#discussion_r2404690254
##########
datafusion-examples/examples/memory_pool_execution_plan.rs:
##########
@@ -247,9 +248,7 @@ impl ExecutionPlan for BufferingExecutionPlan {
children[0].clone(),
)))
} else {
- Err(DataFusionError::Internal(
- "BufferingExecutionPlan must have exactly one
child".to_string(),
- ))
+ internal_err!("BufferingExecutionPlan must have exactly one child")
Review Comment:
There are places we are using `Err(internal_datafusion_err!`, instead of
`internal_err!`, not sure if we should handle those too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
