milenkovicm commented on code in PR #17966:
URL: https://github.com/apache/datafusion/pull/17966#discussion_r2413849310
##########
datafusion/proto/tests/cases/roundtrip_physical_plan.rs:
##########
@@ -2221,3 +2224,41 @@ async fn roundtrip_memory_source() -> Result<()> {
.await?;
roundtrip_test(plan)
}
+
+#[tokio::test]
+async fn roundtrip_listing_table_with_schema_metadata() -> Result<()> {
+ let ctx = SessionContext::new();
+ let file_format = JsonFormat::default();
+ let table_partition_cols = vec![("part".to_owned(), DataType::Int64)];
+ let data = "../core/tests/data/partitioned_table_json";
+ let listing_table_url = ListingTableUrl::parse(data)?;
+ let listing_options = ListingOptions::new(Arc::new(file_format))
+ .with_table_partition_cols(table_partition_cols);
+
+ let config = ListingTableConfig::new(listing_table_url)
+ .with_listing_options(listing_options)
+ .infer_schema(&ctx.state())
+ .await?;
+
+ // Decorate metadata onto the inferred ListingTable schema
+ let schema_with_meta = config
+ .file_schema
+ .clone()
+ .map(|s| {
+ let mut meta: HashMap<String, String> = HashMap::new();
+ meta.insert("foo.bar".to_string(), "baz".to_string());
+ s.as_ref().clone().with_metadata(meta)
+ })
+ .expect("Must decorate metadata");
+
+ let config = config.with_schema(Arc::new(schema_with_meta));
+ ctx.register_table("hive_style",
Arc::new(ListingTable::try_new(config)?))?;
+
+ let plan = ctx
+ .sql("select * from hive_style limit 1")
+ .await?
+ .create_physical_plan()
+ .await?;
+
+ roundtrip_test(plan)
Review Comment:
Roundtrip test will compare string representation of the plan, which may or
may not print metadata (i'm not sure). Would it make sense to test
`parse_protobuf_file_scan_config(serialize_file_scan_config)` and check if
configs match ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
