rluvaton opened a new pull request, #17968:
URL: https://github.com/apache/datafusion/pull/17968

   ## Which issue does this PR close?
   
   N/A
   
   ## Rationale for this change
   
   In the benchmark `aggregate_vectorized` when benchmarking 
`vectorized_equal_to` passing the same `equal_to_result` mutable slice, causing 
the next iteration to skip any comparison. this is bad as it doesn't benchmark 
the actual comparison and it make benchmarks run dependent on the prev run
   
   ## What changes are included in this PR?
   
   always pass a new mutable slice of equal to result, and added 3 more 
benchmark cases:
   1. 0.75 equal to result true
   2. 0.5 equal to result true
   3. 0.25 equal to result true
   
   ## Are these changes tested?
   
   Benchmarks
   
   ## Are there any user-facing changes?
   
   Nope
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to