Dandandan commented on PR #17906: URL: https://github.com/apache/datafusion/pull/17906#issuecomment-3389735203
> > I wonder if we can move the code to some existing projection pushdown instead? > > Yes this is a great point. I've quickly looked into the execution plan optimizer and I think that `ProjectionPushdown` might be the best fit. `FilterPushdown` might also be a good choice thought. However, we are just pushing down parts of the computation and not the "filter itself". > > If we want to include this optimization I am happy to move it to another rule. I think the optimization makes sense (the plans look better and also looks like benchmark results improves a bit for Q22) and also something similar is done for HashJoinExec. I agree it makes sense to put it in `ProjectionPushdown` :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
