cfmcgrady commented on code in PR #2557:
URL: https://github.com/apache/datafusion-comet/pull/2557#discussion_r2425771682
##########
pom.xml:
##########
@@ -915,6 +915,17 @@ under the License.
</licenseHeader>
</java>
<scala>
+ <includes>
+ <include>src/main/scala/**/*.scala</include>
+ <include>src/test/scala/**/*.scala</include>
+ <include>src/main/scala/**/*.sc</include>
+ <include>src/test/scala/**/*.sc</include>
+ <!-- Include spark shim sources -->
+ <include>src/main/spark-*/**/*.scala</include>
+ <include>src/test/spark-*/**/*.scala</include>
+ <include>src/main/spark-*/**/*.cc</include>
+ <include>src/test/spark-*/**/*.cc</include>
+ </includes>
Review Comment:
nit: actually, there are no files with the '.sc' extension in the codebase.
```suggestion
<includes>
<include>src/main/scala/**/*.scala</include>
<include>src/test/scala/**/*.scala</include>
<!-- Include spark shim sources -->
<include>src/main/spark-*/**/*.scala</include>
<include>src/test/spark-*/**/*.scala</include>
</includes>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
