andy-hf-kwok commented on issue #2255: URL: https://github.com/apache/datafusion-comet/issues/2255#issuecomment-3399063854
@comphead My original thought was to work on this module by module and eventually make the whole codebase comply with standard, however by working on https://github.com/apache/datafusion-comet/pull/2558 I reckon that may be too much for PR to cater all hygiene issues at once. Hence instead I reckon that would be better to tackle one warning at a time for the whole codebase, to make the PR be more focused. Ex: one PR to fix all `-Ywarn-numeric-widen` issue so on and so forth. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
