Dandandan commented on code in PR #18029:
URL: https://github.com/apache/datafusion/pull/18029#discussion_r2428129221
##########
datafusion/physical-optimizer/src/limit_pushdown_past_window.rs:
##########
@@ -51,83 +79,62 @@ impl PhysicalOptimizerRule for LimitPushPastWindows {
if !config.optimizer.enable_window_limits {
return Ok(original);
}
- let mut latest_limit: Option<usize> = None;
- let mut latest_max = 0;
+ let mut ctx = TraverseState::default();
Review Comment:
I wonder if we can / should move the code to LimitPushdown instead?
Might be possible to do it in a single pass and simplify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
