comphead commented on code in PR #2568:
URL: https://github.com/apache/datafusion-comet/pull/2568#discussion_r2430423228
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -79,6 +89,7 @@ object CometConf extends ShimCometConf {
.createWithDefault(sys.env.getOrElse("ENABLE_COMET", "true").toBoolean)
val COMET_NATIVE_SCAN_ENABLED: ConfigEntry[Boolean] =
conf("spark.comet.scan.enabled")
Review Comment:
i was thinking overall, if we introduce the category would it be good to
have param names to include category as well.
For example
```
val COMET_ENABLED: ConfigEntry[Boolean] = conf("spark.comet.enabled")
.category(CATEGORY_EXEC)
.doc(...)
```
would be like
```
CATEGORY_EXEC = "spark.comet.exec"
val COMET_ENABLED: ConfigEntry[Boolean] = conf("${CATEGORY_EXEC}.enabled")
.category(CATEGORY_EXEC)
.doc(...)
```
it would def require to rename a lot of params but would give quite
consistent naming pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
