andygrove commented on issue #2572: URL: https://github.com/apache/datafusion-comet/issues/2572#issuecomment-3412619683
> > Maybe the default number of Tokio worker threads should be aligned with the number of Spark executor cores. > > Is it necessary to create a PR for alignment? [@andygrove](https://github.com/andygrove) [@mbutrovich](https://github.com/mbutrovich) We added this to the tuning guide: ``` It is recommended that COMET_WORKER_THREADS be set to the number of executor cores. This may not be necessary in some environments, such as Kubernetes, where the number of cores allocated to a pod will already be equal to the number of executor cores. ``` @zuston are you asking/suggesting that we try and automate this by passing the number of executor cores into native lib and dynamically adjusting the tokio thread pool size instead of relying on an env var? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
