pepijnve commented on PR #17973: URL: https://github.com/apache/datafusion/pull/17973#issuecomment-3389175473
> I agree with the change in evaluate_selection > Now that evaluate_selection is changed, do we need those lines here? @findepi For some reason I could not reply to https://github.com/apache/datafusion/pull/17973#discussion_r2419023180. Yes I would prefer to keep that. Calling `evaluate_selection` still has to produce _a_ value –it can't return `None`– so you pay at least a non-zero cost for calling it unnecessarily. If it's obvious that it will not perform any useful work, it makes sense to avoid it IMO. Just for context, the queries I'm working on are quite `case` heavy. Any work we can save in the inner loop of the queries seems worthwhile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
