duongcongtoai commented on PR #17915: URL: https://github.com/apache/datafusion/pull/17915#issuecomment-3373450436
some error on memory reservation, i'm not sure if the calculation if `fn size` is wrong, but as i understand, we only account for the buffer newly created by the implementation, not the buffer we borrowed somewhere (i.e the stacked ArrayRef everytime we receive from `fn merge_batch` or `fn update_batch`. Maybe it's a good chance for me learn how mem reservation/spilling works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
