alamb commented on PR #17813: URL: https://github.com/apache/datafusion/pull/17813#issuecomment-3382935229
> This is a schema change, and it seems this is not being handled entirely correctly causing the panic later on. The schema for the logical plan still has nullable = false, but the derived physical expression for the case returns nullable = true. Should this be mismatch be resolved during logical plan rewriting or is this a violation of the simplify contract? I believe it is a violation of the (unwritten) `simplify` contract. > nvl and nvl2 do not perform the lazy evaluation simplification that was added to coalesce. Would it make sense to try to align all of these? Basically redirect all these conditional expressions to case and then make that code path as efficient as possible. I think this makes a lot of sense to me I am reviewing this PR more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
