rluvaton commented on code in PR #17979:
URL: https://github.com/apache/datafusion/pull/17979#discussion_r2417601890
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/primitive.rs:
##########
@@ -217,22 +217,22 @@ mod tests {
use std::sync::Arc;
use
crate::aggregates::group_values::multi_group_by::primitive::PrimitiveGroupValueBuilder;
- use arrow::array::{ArrayRef, Int64Array, NullBufferBuilder};
- use arrow::datatypes::{DataType, Int64Type};
+ use arrow::array::{ArrayRef, Float32Array, Int64Array, NullBufferBuilder};
+ use arrow::datatypes::{DataType, Float32Type, Int64Type};
use super::GroupColumn;
#[test]
fn test_nullable_primitive_equal_to() {
- let append = |builder: &mut PrimitiveGroupValueBuilder<Int64Type,
true>,
+ let append = |builder: &mut PrimitiveGroupValueBuilder<Float32Type,
true>,
Review Comment:
I changed the helper method type to use float32 instead of int64 so all
tests in the future that uses the helper will test that as well
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/primitive.rs:
##########
@@ -248,15 +248,15 @@ mod tests {
#[test]
fn test_nullable_primitive_vectorized_equal_to() {
- let append = |builder: &mut PrimitiveGroupValueBuilder<Int64Type,
true>,
+ let append = |builder: &mut PrimitiveGroupValueBuilder<Float32Type,
true>,
Review Comment:
I changed the helper method type to use float32 instead of int64 so all
tests in the future that uses the helper will test that as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
