simonvandel commented on code in PR #17925:
URL: https://github.com/apache/datafusion/pull/17925#discussion_r2404575668
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -291,7 +291,9 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
)))
}
- SQLExpr::TypedString { data_type, value } =>
Ok(Expr::Cast(Cast::new(
+ SQLExpr::TypedString(TypedString {
+ data_type, value, ..
Review Comment:
Would it be better to avoid the `..` and explicitly handle the new field? I
think it's good to get compiler errors if new fields are added that we need to
consider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
