Jefffrey opened a new issue, #18150:
URL: https://github.com/apache/datafusion/issues/18150

   ### Is your feature request related to a problem or challenge?
   
   #14837 introduced support for async UDFs. As part of it, in the physical 
planner it rewrites projections, filters (and inputs to aggregations by #17619).
   
   Projection:
   
   
https://github.com/apache/datafusion/blob/e323357b1e245d8651183e42747cb92709cb1998/datafusion/core/src/physical_planner.rs#L2244-L2271
   
   Filter:
   
   
https://github.com/apache/datafusion/blob/e323357b1e245d8651183e42747cb92709cb1998/datafusion/core/src/physical_planner.rs#L834-L875
   
   Aggregation input:
   
   
https://github.com/apache/datafusion/blob/e323357b1e245d8651183e42747cb92709cb1998/datafusion/core/src/physical_planner.rs#L745-L785
   
   I find this quite confusing to understand and it can cause issues (see 
#18149).
   
   There was also discussion about this in the original async UDF function:
   - 
https://github.com/apache/datafusion/pull/14837#pullrequestreview-2831040913
   - https://github.com/apache/datafusion/pull/14837#discussion_r2083479793
   
   ### Describe the solution you'd like
   
   Either we try to clean up this rewrite logic and do it earlier, or see if we 
can design in a way to not need to rewrite at all (see original PR as there 
seemed to be some discussion towards that direction).
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to