alamb commented on issue #16688: URL: https://github.com/apache/datafusion/issues/16688#issuecomment-3371890527
Thanks @corasaurus-hex I agree it looks like we can improve the code in this area What I would suggest is: 1. Proceed with your PR, even if it isn't ideal (e.g. replicate ArrowOpener if needed), and ensure all the code is well tested 2. File any relevant upstream tickets to improve the APIs > I should be trying to combine things like I am That sound great in theory, but I am not really sure until we see what it looks like. By default, I would defer to the person implementing the feature (you) Also, as long as we have good test coverage of the feature, we can always refactor / improve the code as follow on PRs Thank you for all your help in this area -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
