sunng87 opened a new pull request, #17985:
URL: https://github.com/apache/datafusion/pull/17985

   ## Which issue does this PR close?
   
   N/A
   
   ## Rationale for this change
   
   The implementation of binary operators, especially for regex and bitwise, is 
a little bit difficult to read and understand. 
   
   - the macro for bitwise are actually generic for all integers
   - macros for regexp operator is not necessary and can be simplified to 
function
   - some macros sits in binary.rs, while others in kernels
   
   ## What changes are included in this PR?
   
   - update naming of bitwise macros
   - moved regexp macros into kernel.rs and refactored into functions when its 
possible, removed duplicated macros
   
   ## Are these changes tested?
   
   Unit tests
   
   ## Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to