wForget commented on code in PR #2481:
URL: https://github.com/apache/datafusion-comet/pull/2481#discussion_r2387112098
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -915,6 +915,8 @@ object QueryPlanSerde extends Logging with CometExprShim {
case l @ Length(child) if child.dataType == BinaryType =>
withInfo(l, "Length on BinaryType is not supported")
None
+ case r @ Reverse(child) if child.dataType.isInstanceOf[ArrayType] =>
+ convert(r, CometArrayReverse)
Review Comment:
> Can we just use `convert(expr, CometScalarFunction("array_reve`
Ignore this comment, I'm not sure which way we lean. cc @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
