comphead commented on code in PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#discussion_r2436920403
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -558,15 +558,15 @@ abstract class CometTestBase
opt match {
case Some(i) =>
record.add(0, i % 2 == 0)
- record.add(1, i.toByte)
- record.add(2, i.toShort)
+ record.add(1, i.toByte.toInt)
Review Comment:
same, can be probably converted directly
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -1104,8 +1104,8 @@ abstract class CometTestBase
val record = new SimpleGroup(schema)
opt match {
case Some(i) =>
- record.add(0, i.toByte)
- record.add(1, i.toShort)
+ record.add(0, i.toByte.toInt)
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
