vegarsti commented on code in PR #17891:
URL: https://github.com/apache/datafusion/pull/17891#discussion_r2431099994
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -145,6 +145,7 @@ impl ScalarUDFImpl for ArrayHas {
let list = scalar_values
.into_iter()
.flatten()
+ .flatten()
Review Comment:
@Jefffrey Coming back to this -- I am seeing similar variability in my
benchmarking results for other changes which don't make any sense should affect
the benchmarks. Maybe I'm somehow introducing noise to the results when I'm
benchmarking. It would be great to have your this ^ in main, because it seems a
lot better imo. I'll see if I can get a more stable benchmark result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
