alamb opened a new pull request, #17903:
URL: https://github.com/apache/datafusion/pull/17903

   ## Which issue does this PR close?
   
   
   - part of https://github.com/apache/datafusion/issues/15791
   
   
   
   ## Rationale for this change
   I found that the enforce_sorting tests need many updates (b/c the plan output
   changed) while working on the arrow 57 upgrade, and I am trying to make the
   enforce_sorting tests easier to maintain.
   - https://github.com/apache/datafusion/pull/17888
   
   At the moment the module is huge ([almost 4000 
lines](https://github.com/apache/datafusion/blob/00f05c2212365678ee3485021954c42a28bd19ad/datafusion/core/tests/physical_optimizer/enforce_sorting.rs#L3977))
 it is totally unobvious (to me) that there are **two** macros called
   "assert_optimized_plan" in enforce_sorting.rs and there is one giant test 
test function
   with many cases in it.
   
   I will refactor it in a follow on PR; The first step is to split the test
   into its own module.
   
   
   ## What changes are included in this PR?
   
   Move `test_window_partial_constant_and_set_monotonicity` into its own module
   
   ## Are these changes tested?
   
   Yes, by CI
   
   
   ## Are there any user-facing changes?
   
   no this is a development process nly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to