takluyver opened a new pull request, #2071: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2071
I just tried out the new CREATE TRIGGER support for SQLite, but ran across a limitation. SQLite's [CREATE TRIGGER](https://sqlite.org/lang_createtrigger.html) statement makes the period (`BEFORE`, `AFTER`, `INSTEAD OF`) optional. Leaving it out is equivalent to BEFORE. This allows that in sqlparser, making the field an `Option<TriggerPeriod>`. This is may well be clumsily implemented - I don't write all that much Rust, so suggestions are welcome. I've enabled this only for SQLite for now - I haven't researched if the same syntax is legal in any other dialects. cc @LucaCappelletti94 - and thanks for adding the overall CREATE TRIGGER support :slightly_smiling_face: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
