andygrove opened a new issue, #17987:
URL: https://github.com/apache/datafusion/issues/17987
### Describe the bug
Comet recently replaced its own implementation of `DateAdd` with the version
in `datafusion-spark`, and we found a regression where overflows are not caught
in release builds.
The fix is likely as simple as using checked operations, so replacing ...
```rust
|date, days| date + days,
```
... with ...
```rust
|date, days| date.checked_add(days).unwrap(), // TODO with
appropriate error handling, of course
```
This likely affects `SparkDateSub` as well.
### To Reproduce
_No response_
### Expected behavior
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
