alamb opened a new pull request, #17952: URL: https://github.com/apache/datafusion/pull/17952
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Another try at https://github.com/apache/datafusion/pull/17903 ## Rationale for this change I am working on the arrow 57 upgrade and I found I had to update the output of many tests. I broke some of the changes out into their own PR for easier review This one in particular breaks the 1200+ line test `test_window_partial_constant_and_set_monotonicity`, including 47 test cases in into individual tests so they are easier to update. Without this change, updating all 47 tests requires running the following commands in a loop: ```shell cargo test --profile=ci --test core_integration -- enforce_sorting # fails on the first diff cargo insta review # (and then hit a to accept the changes for the first diff) ``` ## What changes are included in this PR? 1. Move the code to a new file 2. Move testing code into functions rather than a macro 3. Rewrite all test cases (used copilot) ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 4. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
