comphead commented on code in PR #17651:
URL: https://github.com/apache/datafusion/pull/17651#discussion_r2388420201


##########
datafusion/optimizer/src/decorrelate_predicate_subquery.rs:
##########
@@ -371,6 +371,50 @@ fn build_join(
         (None, None) => lit(true),
         _ => return Ok(None),
     };
+
+    if matches!(join_type, JoinType::LeftMark | JoinType::RightMark) {
+        let right_schema = sub_query_alias.schema();
+
+        let mut needed = std::collections::HashSet::new();

Review Comment:
   appreciate if you can added comment what is `needed` ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to