Jefffrey commented on issue #14701: URL: https://github.com/apache/datafusion/issues/14701#issuecomment-3419742933
> It seems like state_fields is really a property of the accumulator, not of the aggregate (as various aggregates may produce different accumulators depending on the options and which accumulator function is called), so it might be better to have the state_fields function on the accumulator instead of the aggregate. I would really love this option; I ran into an issue with this before since the two functions are linked but not spatially co-located so it was hard to realize they needed to be changed together, see my comment: https://github.com/apache/datafusion/pull/17255#discussion_r2295094013 I don't know the wider impacts if we try something like that but I can try explore a bit when I have some time 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
