alamb commented on code in PR #18129:
URL: https://github.com/apache/datafusion/pull/18129#discussion_r2443483616
##########
datafusion/common/src/dfschema.rs:
##########
@@ -1596,6 +1601,35 @@ mod tests {
&DataType::Int16
));
+ // Succeeds if decimal precision and scale are different
+ assert!(DFSchema::datatype_is_semantically_equal(
Review Comment:
these decimal tests appear to have been backported from main without the
corresponding code. I will remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
