adriangb commented on code in PR #18192:
URL: https://github.com/apache/datafusion/pull/18192#discussion_r2448494037
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -865,6 +865,10 @@ message PhysicalExprNode {
UnknownColumn unknown_column = 20;
}
+
+ // Optional ID for caching during deserialization.
+ // Set to the Arc pointer address during serialization to enable
deduplication.
Review Comment:
The thing is we're not really using the addresses as pointers, just as a way
to identify which two expressions are the same expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
