andygrove opened a new issue, #2627:
URL: https://github.com/apache/datafusion-comet/issues/2627

   ### What is the problem the feature request solves?
   
   In https://github.com/apache/datafusion-comet/pull/2614 the function 
signatures were improved so that they specify which data types are accepted, 
rather than just specifying the number of parameters. This helped reduce the 
number of invalid queries that were generated.
   
   However, this was a manual effort and it would be better if we could 
automate this somehow.
   
   Some ideas mentioned by @wForget in 
https://github.com/apache/datafusion-comet/pull/2614#issuecomment-3431489253 
are:
   
   - Get input types from 
[ExpectsInputTypes](https://github.com/apache/spark/blob/3109488d1f5afc9ef2a419c8972ddb0e9fff6610/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpectsInputTypes.scala#L43)
 trait
   - Parse function signatures from example sql, refer: 
[ExpressionsSchemaSuite.scala](https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala)
   - Parse argument number from function desc, like _FUNC_(str, charset) in 
[org.apache.spark.sql.catalyst.expressions.Encode 
desc](https://github.com/apache/spark/blob/3109488d1f5afc9ef2a419c8972ddb0e9fff6610/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala#L3155)
 
   
   ### Describe the potential solution
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to