adriangb commented on PR #18238: URL: https://github.com/apache/datafusion/pull/18238#issuecomment-3437450702
> > Amazing! Could you just add some tests for both the working case and the error case? Maybe also with something slightly more interesting than `SELECT 1;` > > For sure. Is the `NotImplemented` error the route we want to take if the statement isn't a Query? If so, I'll add a few tests next. Yes I just don't know when that would be hit, it would be good to have an example of when that code path gets hit for future reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
