EmilyMatt commented on code in PR #2638:
URL: https://github.com/apache/datafusion-comet/pull/2638#discussion_r2456458338
##########
native/core/src/parquet/mod.rs:
##########
@@ -66,9 +63,9 @@ use datafusion::physical_plan::ExecutionPlan;
use datafusion::prelude::{SessionConfig, SessionContext};
use futures::{poll, StreamExt};
use jni::objects::{
- JBooleanArray, JByteArray, JLongArray, JMap, JObject, JPrimitiveArray,
JString, ReleaseMode,
+ JBooleanArray, JByteArray, JLongArray, JMap, JObject, JObjectArray,
JString, ReleaseMode,
};
-use jni::sys::{jstring, JNI_FALSE};
+use jni::sys::{jintArray, JNI_FALSE};
Review Comment:
Unfortunately when we return from a JNI function we need to return a raw obj
because of the lifetime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
