Weijun-H commented on code in PR #18237: URL: https://github.com/apache/datafusion/pull/18237#discussion_r2456631895
########## docs/source/contributor-guide/index.md: ########## @@ -175,3 +175,27 @@ The good thing about open code and open development is that any issues in one ch Pull requests will be marked with a `stale` label after 60 days of inactivity and then closed 7 days after that. Commenting on the PR will remove the `stale` label. + +## AI-Assisted contributions + +DataFusion has the following policy for AI-assisted PRs: + +- The PR author should **understand the core ideas** behind the implementation **end-to-end**, and is able to defend the design and code during review. Review Comment: nit ```suggestion - The PR author should **understand the core ideas** behind the implementation **end-to-end**, and be able to defend the design and code during review. ``` ########## docs/source/contributor-guide/index.md: ########## @@ -175,3 +175,27 @@ The good thing about open code and open development is that any issues in one ch Pull requests will be marked with a `stale` label after 60 days of inactivity and then closed 7 days after that. Commenting on the PR will remove the `stale` label. + +## AI-Assisted contributions + +DataFusion has the following policy for AI-assisted PRs: + +- The PR author should **understand the core ideas** behind the implementation **end-to-end**, and is able to defend the design and code during review. +- **Calls out unknowns and assumptions**. It's okay to not fully understand some bits of AI generated code. You should comment on these cases and point them out to reviewers so that they can use their knowledge of the codebase to clear up any concerns. For example, you might comment "calling this function here seems to work but I'm not familiar with how it works internally, I wonder if there's a race condition if it is called concurrently". + +### Why fully AI-generated PRs without understanding are not helpful + +Today, AI tools cannot reliably make complex changes to DataFusion on their own, which is why we rely on pull requests and code review. + +The purposes of code review are: + +1. Finish the intended task. +2. Share knowledge between authors and reviewers, as a long-term investment in the project. For this reason, even if someone familiar with the codebase can finish a task quickly, we're still happy to help a new contributor work on it even if it takes longer. + +An AI dump for an issue doesn’t meet these purposes. Maintainers could finish the task faster by using AI directly, and little knowledge is shared if the author does not intend to understand the solution. + +Please understand the reviewing capacity is **very limited** for the project, so such PRs might be closed or get redirected. + +### Better ways to contribute than an “AI dump” + +It's recommended to write a high-quality issue with a clear problem statement and a minimal, reproducible example. This can make it easier for others to contribute. Review Comment: 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
