Jefffrey commented on code in PR #18269:
URL: https://github.com/apache/datafusion/pull/18269#discussion_r2460814901
##########
docs/source/library-user-guide/upgrading.md:
##########
@@ -116,6 +116,35 @@ Users may need to update their paths to account for these
changes.
See [issue #17713] for more details.
+### `FileScanConfigBuilder` now uses `TableSchema` internally
+
+The `FileScanConfigBuilder` has been refactored to use `TableSchema` directly
instead of managing `file_schema` and `table_partition_cols` separately. This
simplifies the builder's internal state management and makes the API more
consistent.
+
+**Impact:** This change is mostly internal and should not affect most users.
The public API of `FileScanConfigBuilder` remains the same - you still use
`with_table_partition_cols()` to set partition columns.
+
+However, if you were directly constructing `FileScanConfigBuilder` from a
`FileScanConfig` (via the `From` trait) or accessing its internal fields, you
may need to update your code.
+
+**Before:**
+
+```rust,ignore
+let builder = FileScanConfigBuilder {
+ file_schema: my_schema,
+ table_partition_cols: partition_cols,
+ ...
+};
+```
Review Comment:
I think this is a hallucination? Fields in `FileScanConfigBuilder` aren't
public so users wouldn't be able to construct it manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
